Update ToSqlVisitor.java#3
Merged
ajermakovics merged 1 commit intoajermakovics:masterfrom Jun 18, 2018
Merged
Conversation
- Add SQL string quotation for strings. Otherwise the SQL query is not valid. - Only make first letter of variable lowercase. `private String firstName;` will be called "firstName" on database, not "firstname". - Only replace method names that start with "get". Boolean getters have the same name as the private variable. For example the getter for `private boolean isUnderAge;` would be `public boolean isUnderAge();` and not `public boolean getIsUnderAge();`.
ajermakovics
approved these changes
Jun 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
private String firstName;will be called "firstName" on database, not "firstname".private boolean isUnderAge;would bepublic boolean isUnderAge();and notpublic boolean getIsUnderAge();.