Skip to content

SQL Assignment-1 take 1#1

Open
akavalek wants to merge 2 commits intomainfrom
assignment-one
Open

SQL Assignment-1 take 1#1
akavalek wants to merge 2 commits intomainfrom
assignment-one

Conversation

@akavalek
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

I am trying submit this week's assignment (the entity relationship diagram and the querying questions excluding the date function questions)

What did you learn from the changes you have made?

I learned about entity relationship diagrams and what the different types of relationships mean. I also learned about temp tables and the having clause!

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I was thinking about selecting another set of tables for the entity relationship diagram but opted for something simple isntead.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

I learned that there multiple ways to query the same results in SQL and that each type of querying platforn is slightly different. It too a lot of getting used to and I made a lot of silly mistakes in the process.

How were these changes tested?

I ran my queries in SQLite.

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@DwardEE DwardEE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! You logical model looks great and proffessional!

Some changes needed in thes questions: in the first SELECT section, the 10-row query has a small ordering syntax issue; give that a quick pass. In WHERE Q1, double-check you’re filtering on the intended ID. For WHERE Q2, your AND version is good. In the “spent > $2000” list, let's use a join that preserves all customers and group by a stable identifier in addition to names.

@akavalek
Copy link
Copy Markdown
Owner Author

Hey @DwardEE - sorry i just saw this message. Thank you for the feedback!! I am working on your requested changes today and will hopefully have them ready for you to review by today (tomorrow at the latest)

@akavalek
Copy link
Copy Markdown
Owner Author

Hey @DwardEE - just commit my fixes to this pull request. Are you able to see my most recent commit (see screenshot for reference) or would you like me to create a new pull request?
SQL Assigment 1 second commit with fixes

Copy link
Copy Markdown

@DwardEE DwardEE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants