Open
Conversation
DwardEE
approved these changes
Aug 20, 2025
DwardEE
left a comment
There was a problem hiding this comment.
Good job on your answer. There are no issues with your diagram,
For your DELETE subquery, it uses MIN(snapshot_timestamp) across the whole table, not scoped to the same product.
Ultimately, no major issues with the assignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Trying to submit SQL assignment 2 for the first time!
What did you learn from the changes you have made?
There are diferent ways use CTEs vs temp tables - while I understand temp tables better, CTEs seem to be much more efficient
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
For the best and worst day seling question - I tried to use a CTE but I kept getting errors - so I went with the temp table option.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Best and worst day selling question was though. The delete row and the update table question at the end took a lot of time and trial and errror.
How were these changes tested?
Ran the queries in SQL
A reference to a related issue in your repository (if applicable)
Checklist