Remove check for method name without "dot" separator#23
Merged
akopdev merged 2 commits intoakopdev:masterfrom Jul 8, 2024
Merged
Remove check for method name without "dot" separator#23akopdev merged 2 commits intoakopdev:masterfrom
akopdev merged 2 commits intoakopdev:masterfrom
Conversation
There are valid methods like "methods" and "scope" that do not have a "dot" separator within their name. According to the documentation and a "methods" call, there are 5 such methods: ['batch', 'scope', 'methods', 'events', 'profile']
Owner
|
Hi, thank you for your proposal. I don't have any strong arguments to keep this validation. Could you please bump the package version to |
Contributor
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are valid methods like "methods" and "scope" that do not have a "dot" separator within their name.
According to the documentation and a "methods" call, there are 5 such methods: ['batch', 'scope', 'methods', 'events', 'profile']
If there's a strong reason for keeping this check, it could instead add a check for manually allowing these five methods, but that seems janky to me.