test: add unit tests for UUIDStringUtils#3
Draft
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Draft
test: add unit tests for UUIDStringUtils#3devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: aneesharma1 <[email protected]>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds 10 unit tests for
UUIDStringUtils, which previously had zero test coverage. This utility convertsUUIDand rawlongvalues into Sentry's dash-free lowercase hex ID strings and is used internally bySentryIdandSpanId.Tests cover:
toSentryIdString(32-char output): known UUID, all-zeros, all-ones,long-based overload consistencytoSentrySpanIdString(16-char output): known UUID, all-zeros, all-ones,long-based overload consistency💡 Motivation and Context
UUIDStringUtilsis a foundational utility — if its hex encoding is wrong, every event ID and span ID in the SDK is wrong. Despite this, it had no dedicated tests. This is a test-only change with no production code modifications.💚 How did you test it?
Reviewer checklist
a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11→a0eebc999c0b4ef8bb6d6bb9bd380a11)📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Other zero-coverage utility classes in
sentry/utilthat could benefit from the same treatment:ClassLoaderUtils,ErrorUtils,Objects,Pair.Link to Devin session: https://app.devin.ai/sessions/23aaff7eb99e45c79503152f36003ab8
Requested by: @aks4396