Open
Conversation
kirillNay
approved these changes
May 3, 2023
| double totalPrice=0; | ||
| String totalProduct = "" ; | ||
|
|
||
| public void priceEntry() { |
There was a problem hiding this comment.
⏫ Так как функция priceEntry используется только внутри класса Calculator, мы можем сделать ее private
| else { | ||
| System.out.println("вы выбрали "+ nameOfProduct); | ||
| totalProduct = totalProduct +"\n"+ nameOfProduct; | ||
| priceEntry(); |
There was a problem hiding this comment.
⏫ Так как такая конкатенция строк будет создавать новый объект String каждый раз, можно воспользоваться более оптимизированным способом формирования строки - с помощью StringBuilder, и добавлять строку с помощью метода append
|
|
||
| } else if (valueOfPeople <= 0 ) { | ||
| System.out.println("Введены некорректные данные, попробуйте еще раз"); | ||
| scanner1.nextLine(); |
There was a problem hiding this comment.
⏫ Эти два условия можно было бы объединить под
if (valueOfPeople <= 0 || valueOfPeople > 20000) {...}
kirillNay
approved these changes
May 3, 2023
| System.out.println("Hello world!"); | ||
| Person person = new Person(); | ||
| Calculator calculator = new Calculator(); | ||
| person.numberOfPerson(); |
There was a problem hiding this comment.
⏫ Обычно функции, которые выполняют какое-либо действие принято называть глаголами. В твоем случае было бы удобнее назвать:
enterNumberOfPersons()enterProducts()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проектная работа номер 1 на проверку.