Open
Conversation
added 7 commits
January 16, 2025 17:32
kelichiu
suggested changes
Jan 26, 2025
There was a problem hiding this comment.
Point: 28/30
Section 1: ✅ Complete
Section 2: ✅ Complete
Section 3: ☑️ Partial
Aggregate Question 2
You are very close! You have the correct set of customers output in the result, and you have correctly joined the two tables together.
Todo:
- You will need to display their total spending as well. Make an additional column from the calculation you have in the HAVING statement, give it a column name
- You will need to sort the result. Sort the result by customer's last name, then first name
- Not a must, but consider using table alias to shorten the table names in your queries
Date Question 2
You are also very close on this one! And I appreciate that you used temp table to complete this question.
Todo:
- Check the correct number representation of "April"
- Display additional columns of month and year
Section 4: ✅ Complete
Thank you Faiyza for the wonderful reflection! It's personal, thoughtful, and you have brought in valuable insights. It was a enjoyable read indeed.
kelichiu
approved these changes
Jan 27, 2025
kelichiu
left a comment
There was a problem hiding this comment.
2nd assessment point: 30/30
Section 1: ✅ Complete
Section 2: ✅ Complete
Section 3: ✅ Complete
Section 4: ✅ Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist