Fixed (type,name) ordering for tkvarentry.#34
Merged
alejandroautalan merged 1 commit intoalejandroautalan:masterfrom Sep 21, 2014
Merged
Fixed (type,name) ordering for tkvarentry.#34alejandroautalan merged 1 commit intoalejandroautalan:masterfrom
alejandroautalan merged 1 commit intoalejandroautalan:masterfrom
Conversation
This was referenced Sep 19, 2014
Closed
alejandroautalan
added a commit
that referenced
this pull request
Sep 21, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having issues with the type and the variable name getting mangled in the UI as well as when the xml was read back in by the builder.
In the _get_value() method the ordering of the pair was parsed as (name, type) whereas in the _set_value() method as well as the builder it is (type, name). I changed it in the _get_value() method to minimize the number of files touched.