Open
Conversation
juliagallucci
approved these changes
May 6, 2024
juliagallucci
left a comment
There was a problem hiding this comment.
Great! Your code is well-commented and executes without error. One suggestion would be to remove any lines of code that are not needed; ie if len(word_a) != len(word_b):
return False
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Added logic for Anagram checker function.
What did you learn from the changes you have made?
Played around with the python functions and noticed that PyCharm community edition does not support Jupyter notebooks.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
For checking the anagram pattern, another approach can be finding each character in word a in word b and making sure the index of the character does not overlap. But this approach is more complicated.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Pycharm Community edition does not support jupyter notebooks so I switched to vs code.
How were these changes tested?
Ran the code in the cell.
A reference to a related issue in your repository (if applicable)
N/A
Checklist