Open
Conversation
michaeladrouillard
approved these changes
May 15, 2024
michaeladrouillard
left a comment
There was a problem hiding this comment.
great! for question 2, you don't actually have to initialize summary_values = None. it's redundant. however, totally harmless and fine if for instance you want to focus on code readability or something :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding new functions
What did you learn from the changes you have made?
Played around with the np package. Np is a very powerful tool for analyzing different format for datasets and is very smart too.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Not really as np has very good built in functions.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I was trying to understand the multidimensional arrays and the slides are very helpful.
How were these changes tested?
I ran the functions with different arguments to ensure the output was what I expected.
A reference to a related issue in your repository (if applicable)
n/A
Checklist