Skip to content

fix: cleanup table footer#341

Merged
tenshiAMD merged 1 commit intomasterfrom
tenshiamd/fix-table-footer
Oct 6, 2022
Merged

fix: cleanup table footer#341
tenshiAMD merged 1 commit intomasterfrom
tenshiamd/fix-table-footer

Conversation

@tenshiAMD
Copy link
Copy Markdown
Member

What:

Why:

  • Cleanup table footer to fix some linters

How:

  • Update implementation

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to the contributors' table

@tenshiAMD tenshiAMD self-assigned this Oct 6, 2022
@tenshiAMD tenshiAMD requested a review from a team as a code owner October 6, 2022 09:44
@tenshiAMD
Copy link
Copy Markdown
Member Author

tenshiAMD commented Oct 6, 2022

TODO:

  • Add snapshot/s for testing footer

Copy link
Copy Markdown

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

@tenshiAMD tenshiAMD force-pushed the tenshiamd/fix-table-footer branch from f165085 to 158d722 Compare October 6, 2022 14:17
@tenshiAMD tenshiAMD merged commit 0be7a63 into master Oct 6, 2022
@tenshiAMD tenshiAMD deleted the tenshiamd/fix-table-footer branch October 6, 2022 14:20
@all-contributors-release-bot
Copy link
Copy Markdown
Member

🎉 This PR is included in version 6.23.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove trailing whitespace (flagged by popular linters)

3 participants