fix: correct escape quotes in contributor names#351
Merged
gr2m merged 3 commits intoall-contributors:masterfrom May 12, 2023
dwmkerr:fix/quotes-in-names
Merged
fix: correct escape quotes in contributor names#351gr2m merged 3 commits intoall-contributors:masterfrom dwmkerr:fix/quotes-in-names
gr2m merged 3 commits intoall-contributors:masterfrom
dwmkerr:fix/quotes-in-names
Conversation
Contributor
Author
|
@all-contributors add dwmkerr for bug tests code |
Contributor
|
I've put up a pull request to add @dwmkerr! 🎉 |
dwmkerr
added a commit
to dwmkerr/effective-shell
that referenced
this pull request
Feb 7, 2023
This fix will not be needed when the following issue is resolved in the mainline: all-contributors/cli#351
Contributor
Author
|
Hey all any updates on when we can get this in? It's a bit of a challenge for my colleagues which special characters in names |
gr2m
approved these changes
May 12, 2023
Contributor
gr2m
left a comment
There was a problem hiding this comment.
Thank you! Sorry for the wait
Member
|
🎉 This PR is included in version 6.25.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
Great, thanks @gr2m ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
This PR fixes issue #352
Why:
Quote in GitHub user names create invalid HTML in the contributors table
How:
Expanding on the technique used to fix pipes in names.
Checklist: