Conversation
|
I'm good with this. @JimMadge, that npm validate essentially ran all CI checks in parallel before deployment. And I think what was happening (please correct me if you see something different!) is that this project has a strict semantic release setup, so CircleCI was deploying based on commit messages, including a major/or minor/patch version. It was deploying frequently as well. I think what we need is a GHA that runs all of these checks on release and then triggers a deployment (using a protected environment). I opened #420 to discuss how we want to release. And then, if we are okay with a manual release that triggers deployment, I'll happily create that workflow because CI is fun, and we can run all the steps from that validate command in sequence within GHA. ✨ Thank you for this!! It's fun to be working with you over here again!! |
|
oh i'll also close my pr! I just removed Circle CI, missing what you did here!! thanks! circleci had permissions issues and i am happy to not have to hunt down the fix for it. |
Same here, I'm happy we are starting to get handle on the CLI. |
Me too!! Gosh i'm learning so much on this project. I think that is one of my favorite parts!! |
Closes #413
Having a look at the script to replace this there is behaviour we would have to reproduce. However, as far as I could tell the only place it was used was in circle CI. So, I'm suggesting we remove it.