WIP Tutorial annotation, URL Explorer, and SVG icons#134
Draft
livcheerful wants to merge 17 commits intoallmaps:developfrom
Draft
WIP Tutorial annotation, URL Explorer, and SVG icons#134livcheerful wants to merge 17 commits intoallmaps:developfrom
livcheerful wants to merge 17 commits intoallmaps:developfrom
Conversation
livcheerful
commented
Sep 5, 2024
| baseUrl: 'https://github.com/allmaps/allmaps/tree/develop/apps/docs/' | ||
| }, | ||
| expressiveCode: { | ||
| themes: ['material-theme'] |
Contributor
Author
There was a problem hiding this comment.
A variety of theme options can be found here: https://expressive-code.com/guides/themes/
or any VS Code theme works!
livcheerful
commented
Sep 5, 2024
| "copy-readmes": "node ./scripts/copy-readmes.js" | ||
| }, | ||
| "dependencies": { | ||
| "@allmaps/iiif-parser": "workspace:^1.0.0-beta.37", |
Contributor
Author
There was a problem hiding this comment.
This is being used to load URLs for the ID explorer
livcheerful
commented
Sep 5, 2024
| "astro": "^4.0.1", | ||
| "expressive-code": "^0.35.3", | ||
| "sharp": "^0.32.3", | ||
| "shiki": "^1.10.3", |
Contributor
Author
There was a problem hiding this comment.
Being used for codeToHtml to style JSON in the ID Explorer
livcheerful
commented
Sep 5, 2024
| "@astrojs/svelte": "^5.0.3", | ||
| "@astrojs/tailwind": "^5.1.0", | ||
| "astro": "^4.0.1", | ||
| "expressive-code": "^0.35.3", |
Contributor
Author
There was a problem hiding this comment.
Used to style code for the Annotated Code Blocks
livcheerful
commented
Sep 5, 2024
| } | ||
|
|
||
| // Add the highlight-line class to all lines included for the given annotation | ||
| const highlightAnnotationLines = (annotationIdx: number) => { |
Contributor
Author
There was a problem hiding this comment.
<Annotation> can't talk to <AnnotationCodeBlock>, so we're communicating through classes.
Annotation will add the lines it wants to highlight into its HTML classes, and AnnotationCodeBlock will read that when it loads in all the rendered HTML elements
livcheerful
commented
Sep 5, 2024
livcheerful
commented
Sep 5, 2024
… into tutorial-annotations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three major changes in this!