Merged
Conversation
Member
|
Looks good. Thanks 👍 |
aalavandhan
approved these changes
May 18, 2020
ahnaguib
approved these changes
May 18, 2020
| transactions[index] = transactions[transactions.length - 1]; | ||
| } | ||
|
|
||
| delete transactions[transactions.length - 1]; |
Contributor
There was a problem hiding this comment.
That's hidden and good to know! we have this delete pattern in multiple places in our codebase.
|
|
||
| destination, | ||
| transferValueWei, | ||
| 0, // transfer value in wei |
Contributor
There was a problem hiding this comment.
I thought we already did this when I left a comment for it in the original PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exhibit 1-
Remove Orchestrator address initialization in the policy.
Exhibit 2-
Reorder Transaction struct elements to pack values and save storage.
Exhibit 3-
No action. I'm ok with leaving the index in the
TransactionFailedevent, since risk is minimal and it aids potential debugging.Exhibit 4-
No action needed.
Exhibit 5-
Removed unnecessary
deletecall.Exhibit 6-
Removed
transferValueWeiparameter in external_call.Exhibit 7-
Remove
dataLengthparameter in external_call. Load directly from array's storage.Exhibit 8-
No action. It doesn't save gas, and I think it's more legible as is.
Exhibit 9-
Renamed
transactionsLengthtotransactionsSizeto follow market-oracle repo's convention.Exhibit 10-
No action needed, since we mitigated Exhibit 2.