Merged
Conversation
aalavandhan
commented
Dec 8, 2022
nms-7
approved these changes
Dec 8, 2022
brandoniles
approved these changes
Dec 8, 2022
96ddc69 to
f1c7c38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the current implementation, there's a bug which results in a
lastIssueWindowTimestampahead of the block.timestamp resulting inbonds > maxDurationbeing created. However the bond length is bounded, bymaxDuration+minIssueTimeIntervalSec. (In our config in certain cases, up to a 35 day bond could be issued not strictly under 28)Consider the following example with
minIssueTimeIntervalSec=3600,issueWindowOffsetSec=900When the timestamp is between the window start and the offset (in this case X:00, X:15), it should snap to the previous hour ie (X-1:15) and NOT (X:15)