Merged
Conversation
Charm Vault manager update
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
d27a583 to
9e39bda
Compare
brandoniles
reviewed
Aug 1, 2024
|
|
||
| VAULT = vault_; | ||
| POOL = vault_.pool(); | ||
| USDC = vault_.token0(); |
Member
There was a problem hiding this comment.
Probably better style to hardcode the expected token addresses, then do a require check on the vault properties on init.
Nothing inherently incorrect with this approach, provided we do a manual spot check on deployment.
9e39bda to
4cf35e9
Compare
53a8c10 to
39bee7f
Compare
brandoniles
reviewed
Aug 5, 2024
Member
brandoniles
left a comment
There was a problem hiding this comment.
LGTM, just the comment update and looks good
Co-authored-by: Brandon Iles <[email protected]>
brandoniles
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.