This repository was archived by the owner on Jan 4, 2024. It is now read-only.
Replace use of GlobalScope with Application CouroutineScope#41
Open
swapnilkadlag wants to merge 1 commit intoandroid:mainfrom
Open
Replace use of GlobalScope with Application CouroutineScope#41swapnilkadlag wants to merge 1 commit intoandroid:mainfrom
swapnilkadlag wants to merge 1 commit intoandroid:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the current usage of
GlobalScopewhile seeding the initial database is not ideal, for the reasons mentioned in the following articlehttps://elizarov.medium.com/the-reason-to-avoid-globalscope-835337445abc
Hence I would like to propose a pull request to replace usage of
GlobalScopewithApplication CoroutineScope#40