build(brocolli): convert brocolli-ts2dart to use TreeDiffer#1733
build(brocolli): convert brocolli-ts2dart to use TreeDiffer#1733caitp merged 1 commit intoangular:masterfrom
Conversation
5945451 to
11563b0
Compare
tools/broccoli/broccoli-ts2dart.ts
Outdated
There was a problem hiding this comment.
is this just temporary? shouldn't this come in via options?
There was a problem hiding this comment.
they probably should come via options
|
the rest looks good to me |
|
PTAL --- added code to remove unneeded files from cache |
|
Travis is not happy, can we get it green? |
|
looks like a clang-format issue. @caitp can you fix please? also what's up with the dgeni warnings? that should not be related to this change. |
|
do you mean the dgeni issues with |
|
yeah. those warnings. On Fri, May 8, 2015 at 11:25 AM ⭐caitp⭐ [email protected] wrote:
|
|
but yes, those aren't related to this change, it's related to migrating to TypeScript, afaik |
|
so, i take it it looks alright? |
tools/broccoli/broccoli-ts2dart.ts
Outdated
There was a problem hiding this comment.
this name is going to show up in logs, can you rename it to the shorter TS2DartTranspiler please?
|
the rest looks fine. can you double check what is being emitted and remove only the files emitted by the transpiler. |
tools/broccoli/broccoli-ts2dart.ts
Outdated
There was a problem hiding this comment.
I don't think that we can do it this way. we need to check if the input contains the dart file just like we do on lines 34-35.
it's possible that the input was:
- fileA.ts
- fileA.dart
then the transpiler will not emit anything and we will reuse the fileA.dart file as the output.
if later fileA.ts is removed, we should not remove fileA.dart because we didn't emit it. it is the responsibility of the previous plugin that gave us a tree that contained fileA.dart file to remove it.
so we need to reimplement the input tree checking logic here as well.
find tmp/diffing_plugin_wrapper-cache_path-JGpT3tqi.tmp/ -type f | sed -En 's|.*/[^/]+\.([^/.]+)$|\1|p' | sort -u
dartSo, just dart files I guess |
8c40959 to
01d18a8
Compare
e7b25c8 to
3dcdd7e
Compare
|
is this ready to go? I see that some tests failed on travis. I wonder if that's a flake. I restarted the build to see... |
|
ci is green.. |
|
Should be ok to land then. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Blocked on #1719
Closes #1720