Skip to content

fix(compiler-cli): report missing pipes when fullTemplateTypeCheck is disabled#39320

Closed
JoostK wants to merge 1 commit intoangular:masterfrom
JoostK:ngtsc/report-missing-pipes
Closed

fix(compiler-cli): report missing pipes when fullTemplateTypeCheck is disabled#39320
JoostK wants to merge 1 commit intoangular:masterfrom
JoostK:ngtsc/report-missing-pipes

Conversation

@JoostK
Copy link
Member

@JoostK JoostK commented Oct 17, 2020

Even if fullTemplateTypeCheck is disabled should missing pipes still
be reported, as was the case in View Engine.

Fixes #38195

@JoostK JoostK added type: bug/fix target: patch This PR is targeted for the next patch release engine: ivy area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 17, 2020
@ngbot ngbot bot added this to the needsTriage milestone Oct 17, 2020
@google-cla google-cla bot added the cla: yes label Oct 17, 2020
@JoostK JoostK mentioned this pull request Oct 17, 2020
Closed
15 tasks
@JoostK
fix(compiler-cli): report missing pipes when fullTemplateTypeCheck …
c4d950c 
…is disabled

Even if `fullTemplateTypeCheck` is disabled should missing pipes still
be reported, as was the case in View Engine.

Fixes angular#38195
@JoostK JoostK force-pushed the ngtsc/report-missing-pipes branch from 0dd4bdf to c4d950c Compare October 17, 2020 18:42
@JoostK JoostK marked this pull request as ready for review October 17, 2020 20:52
@JoostK JoostK added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 17, 2020
@JoostK JoostK requested a review from alxhub October 17, 2020 20:52
@JoostK JoostK added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 30, 2020
josephperrott pushed a commit that referenced this pull request Oct 31, 2020
@JoostK @josephperrott
fix(compiler-cli): report missing pipes when fullTemplateTypeCheck …
71d0063 
…is disabled (#39320)

Even if `fullTemplateTypeCheck` is disabled should missing pipes still
be reported, as was the case in View Engine.

Fixes #38195

PR Close #39320
josephperrott pushed a commit that referenced this pull request Oct 31, 2020
@JoostK @josephperrott
fix(compiler-cli): report missing pipes when fullTemplateTypeCheck …
67ea7b6 
…is disabled (#39320)

Even if `fullTemplateTypeCheck` is disabled should missing pipes still
be reported, as was the case in View Engine.

Fixes #38195

PR Close #39320
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 1, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxhub alxhub alxhub approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit area: compiler Issues related to `ngc`, Angular's template compiler cla: yes target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

Missing pipe not caught by production build with AOT

2 participants

@JoostK @alxhub