Multiple zone callbacks (phase 1)#4822
Merged
yjbanov merged 2 commits intoangular:masterfrom Oct 21, 2015
Merged
Conversation
2ae56ed to
9cd5712
Compare
Contributor
Author
|
/cc @mhevery: this PR contains public API change; need your approval |
Contributor
There was a problem hiding this comment.
Is this better?
after Angular zone -> after the Angular zone
Contributor
|
Mostly looks good. Just a couple of questions, and doc cleanup stuff. |
aeddffc to
5a0d811
Compare
BREAKING CHANGES: - deprecates these methods in NgZone: overrideOnTurnStart, overrideOnTurnDone, overrideOnEventDone, overrideOnErrorHandler - introduces new API in NgZone that may shadow other API used by existing applications.
5a0d811 to
491e1fd
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NgZoneevent Streams/Observables to allow multiple subscribersoverridemethodsfixes #4535
Phase 2 is to clean up usages of deprecated API and delete it.