Skip to content

test(core): Ensure signals can be read after view creation during cha… #52495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
atscott wants to merge 1 commit into from
Closed

test(core): Ensure signals can be read after view creation during cha… #52495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 48 additions & 1 deletion packages/core/test/acceptance/change_detection_signals_in_zones_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import {NgFor, NgIf} from '@angular/common';
import {PLATFORM_BROWSER_ID} from '@angular/common/src/platform_id';
import {afterNextRender, ChangeDetectionStrategy, ChangeDetectorRef, Component, computed, Directive, inject, Input, PLATFORM_ID, signal, ViewChild} from '@angular/core';
import {afterNextRender, ChangeDetectionStrategy, ChangeDetectorRef, Component, computed, Directive, inject, Input, PLATFORM_ID, signal, TemplateRef, ViewChild, ViewContainerRef} from '@angular/core';
import {TestBed} from '@angular/core/testing';

describe('CheckAlways components', () => {
Expand Down Expand Up @@ -628,6 +628,53 @@ describe('OnPush components with signals', () => {
});

describe('embedded views', () => {
describe('with a signal read after view creation during an update pass', () => {
it('should work with native control flow', () => {
@Component({
template: `
@if (true) { }
{{val()}}
`,
standalone: true,
changeDetection: ChangeDetectionStrategy.OnPush,
})
class MyComp {
val = signal('initial');
}

const fixture = TestBed.createComponent(MyComp);
fixture.detectChanges();
fixture.componentInstance.val.set('new');
fixture.detectChanges();
expect(fixture.nativeElement.innerText).toBe('new');
});

it('should work with createEmbeddedView', () => {
@Component({
template: `
<ng-template #template></ng-template>
{{createEmbeddedView(template)}}
{{val()}}
`,
standalone: true,
changeDetection: ChangeDetectionStrategy.OnPush,
})
class MyComp {
val = signal('initial');
vcr = inject(ViewContainerRef);
createEmbeddedView(ref: TemplateRef<{}>) {
this.vcr.createEmbeddedView(ref);
}
}

const fixture = TestBed.createComponent(MyComp);
fixture.detectChanges();
fixture.componentInstance.val.set('new');
fixture.detectChanges();
expect(fixture.nativeElement.innerText).toBe('new');
});
});

it('refreshes an embedded view in a component', () => {
@Component({
selector: 'signal-component',
Expand Down