fix(common): remove assertNoComplexSizes from NgOptimizedImage#67116
Closed
apoorvdarshan wants to merge 1 commit intoangular:mainfrom
Closed
fix(common): remove assertNoComplexSizes from NgOptimizedImage#67116apoorvdarshan wants to merge 1 commit intoangular:mainfrom
apoorvdarshan wants to merge 1 commit intoangular:mainfrom
Conversation
The assertNoComplexSizes assertion throws NG02952 in dev mode when `sizes` contains pixel values (e.g. `370px`). However, pixel values in `sizes` are valid HTML and work correctly in production. This blocks valid use cases like `sizes="(max-width: 540px) 100vw, (max-width: 960px) 50vw, 370px"`. Closes angular#59495
Member
|
We don't want to remove that check entirely, #67070 looks more interesting for example. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assertNoComplexSizesassertion that throws NG02952 in dev mode whensizescontains pixel values (e.g.370px)sizesare valid HTML and work correctly in production, so the assertion blocks valid use cases likesizes="(max-width: 540px) 100vw, (max-width: 960px) 50vw, 370px"Closes #59495
Test plan
bazel test //packages/common/test:test)sizesattributes with pixel values no longer throw NG02952 in dev mode