fix(migrations): prevent trailing comma syntax errors after removing NgStyle#67714
Merged
mattrbeck merged 1 commit intoangular:mainfrom Mar 18, 2026
Merged
Conversation
atscott
requested changes
Mar 16, 2026
Contributor
atscott
left a comment
There was a problem hiding this comment.
AGENT: I have left a few inline suggestions for your consideration.
packages/core/schematics/test/ngstyle_to_style_migration_spec.ts
Outdated
Show resolved
Hide resolved
7f4022d to
54dff79
Compare
Contributor
Author
Fixed and updated the commit |
Contributor
Author
|
Is this a legitimate error? I don't understand why it would affect my fix. |
Member
|
It's a pre-exisiting error. See #67719. |
…NgStyle This fixes an issue where when removing NgStyle from the imports array of a component, an extra trailing comma would be left behind if it was the last element in that component`.
54dff79 to
de6ac17
Compare
atscott
approved these changes
Mar 17, 2026
Member
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where when removing NgStyle from the imports array of a component, an extra trailing comma would be left behind if it was the last element in that component`.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?