Skip to content

feat(core): bootstrap via ApplicationRef with config#67948

Open
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:bootstrap-params
Open

feat(core): bootstrap via ApplicationRef with config#67948
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:bootstrap-params

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche commented Mar 31, 2026

This is to align the shape of the method with createComponent

BREAKING CHANGE=The second arguement of appRef.bootstrap does not accept any anymore. Make sure the element you pass is not nullable.

fixes #67946

@JeanMeche JeanMeche added the action: global presubmit The PR is in need of a google3 global presubmit label Mar 31, 2026
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Mar 31, 2026
@ngbot ngbot bot added this to the Backlog milestone Mar 31, 2026
@JeanMeche JeanMeche requested a review from AndrewKushnir March 31, 2026 21:55
@JeanMeche JeanMeche marked this pull request as ready for review March 31, 2026 21:57
@pullapprove pullapprove bot requested a review from kirjs March 31, 2026 21:57
@pullapprove pullapprove bot requested a review from devversion April 1, 2026 01:07
@AndrewKushnir AndrewKushnir requested review from alxhub and removed request for devversion April 1, 2026 01:07
@JeanMeche JeanMeche force-pushed the bootstrap-params branch 3 times, most recently from e512361 to 70d18ad Compare April 2, 2026 15:25
@JeanMeche JeanMeche force-pushed the bootstrap-params branch 2 times, most recently from 4615392 to 191cfb8 Compare April 2, 2026 15:29
@JeanMeche
Copy link
Copy Markdown
Member Author

I'm marking this a breaking change because we drop the any from the signalture.

@JeanMeche
Copy link
Copy Markdown
Member Author

I think we can actually do with the in operator and reversing the condition.

Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @JeanMeche 👍

Minor comment: the commit message uses BREAKING CHANGE=, should we use the BREAKING CHANGE: (with the colon) instead?

Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir AndrewKushnir added the target: major This PR is targeted for the next major release label Apr 2, 2026
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Apr 2, 2026
This is to align the shape of the method with `createComponent`

BREAKING CHANGE:The second arguement of appRef.bootstrap does not accept `any` anymore. Make sure the element you pass is not nullable.

fixes angular#67946
@JeanMeche JeanMeche removed request for alxhub and kirjs April 2, 2026 23:21
@JeanMeche
Copy link
Copy Markdown
Member Author

JeanMeche commented Apr 3, 2026

Passing TGP

Actually there 1 target that needs to be migrated

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: global presubmit The PR is in need of a google3 global presubmit action: merge The PR is ready for merge by the caretaker labels Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Issues related to the framework runtime breaking changes detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align ApplicationRef.bootstrap contract with createComponent function

2 participants