fix(compiler): handle nested brackets in host object bindings#68044
Open
crisbeto wants to merge 1 commit intoangular:mainfrom
Open
fix(compiler): handle nested brackets in host object bindings#68044crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
Fixes that we were parsing bindings in the `host` object with a regex that didn't account for nested brackets which may come up with something like Tailwind. Fixes angular#68039.
crisbeto
commented
Apr 6, 2026
| hostBindings: function MyComponent_HostBindings(rf, ctx) { | ||
| if (rf & 2) { | ||
| $r3$.ɵɵclassProp("text-primary/80", ctx.expr)("data-active:text-green-300/80", ctx.expr)("data-[size='large'", ctx.expr); | ||
| $r3$.ɵɵclassProp("text-primary/80", ctx.expr)("data-active:text-green-300/80", ctx.expr)("data-[size='large']:p-8", ctx.expr); |
Member
Author
There was a problem hiding this comment.
Fun part is that I captured this in a test back in #62742, but didn't address it 😅
JoostK
approved these changes
Apr 6, 2026
Member
Author
Member
Author
|
This is blocked until we can clean up a couple of internal clients. |
Member
Author
|
Caretaker note: presubmit failure is unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that we were parsing bindings in the
hostobject with a regex that didn't account for nested brackets which may come up with something like Tailwind.Fixes #68039.