refactor(vscode-extension): allow toggle attributes via LS.#68077
Merged
kirjs merged 1 commit intoangular:mainfrom Apr 13, 2026
Merged
refactor(vscode-extension): allow toggle attributes via LS.#68077kirjs merged 1 commit intoangular:mainfrom
kirjs merged 1 commit intoangular:mainfrom
Conversation
atscott
requested changes
Apr 8, 2026
614dd58 to
2ad1fe7
Compare
This change allows to toggle attributes that are on their own line and have a 1+ leading space. This change doesn't suffer from the issue that was reverted in angular#68067. Also this change fixes another regression that messed up highlighting if an attribute value included a '//', like in an href.
2ad1fe7 to
b5423b0
Compare
atscott
approved these changes
Apr 13, 2026
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows to toggle attributes that are on their own line and have a 1+ leading space.
This change doesn't suffer from the issue that was reverted in #68067.
Also this change fixes another regression that messed up highlighting if an attribute value included a '//', like in an href.