chore: upgrade to new Zone.js API v0.6.4#7345
Closed
mhevery wants to merge 1 commit intoangular:masterfrom
Closed
Conversation
8a41411 to
c73d217
Compare
Contributor
Author
There was a problem hiding this comment.
It should say if current == innerZone.
Contributor
Author
There was a problem hiding this comment.
Upon further thought the line is fine.
94d1c41 to
ce7c4f5
Compare
This was referenced Mar 2, 2016
da35d99 to
91bac5d
Compare
Contributor
Author
There was a problem hiding this comment.
add some docs as to why we we have to delay.
Because the operation we just executed was caused by MacroTask (such as setTimeout), when the function gets called we are still inside of the MacroTask. This will make _ngZone.hasPendingMacrotask report outstanding tasks. We need to drain the task by jumping to a microtask.
TODO(misko): Consider having NgZone expos onMacroTaskEmpty hook. (As Zone.js already provides this.)
78c70c9 to
f0220eb
Compare
Closed
fa86d56 to
c4136b1
Compare
BREAKING CHANGE Removed deprecated API from NgZone - `NgZone.overrideOnTurnStart` - `NgZone.overrideOnTurnDone` - `NgZone.overrideOnEventDone` - `NgZone.overrideOnErrorHandler` Rename NgZone API - `NgZone.onTurnStart` => `NgZone.onUnstable` - `NgZone.onTurnDone` => `NgZone.onMicrotaskEmpty` - `NgZone.onEventDone` => `NgZone.onStable`
|
Merging PR #7345 on behalf of @alexeagle to branch presubmit-alexeagle-pr-7345. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Removed deprecated API from NgZone
NgZone.overrideOnTurnStartNgZone.overrideOnTurnDoneNgZone.overrideOnEventDoneNgZone.overrideOnErrorHandler(1 g3 ref)Rename NgZone API
NgZone.onTurnStart=>NgZone.onUnstable(16 g3 ref)NgZone.onTurnDone=>NgZone.onMicrotaskEmpty(38 g3 ref)NgZone.onEventDone=>NgZone.onStable(12 g3 ref)cr/117019088 | tap