chore(build): experimental Docker support for our build#7501
Closed
alexeagle wants to merge 1 commit intoangular:masterfrom
Closed
chore(build): experimental Docker support for our build#7501alexeagle wants to merge 1 commit intoangular:masterfrom
alexeagle wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
Author
|
/cc @edgeprod |
Dockerfile
Outdated
Contributor
Author
There was a problem hiding this comment.
yes, that reduces the changes seen, but need to copy to npm-shrinkwrap.json so npm install will see it, right?
Contributor
|
Lgtm otherwise |
9837762 to
65d7c4a
Compare
Contributor
Author
|
Will leave this work on the docker branch, and not merge to master yet. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.