Skip to content

feat(security): warn users when sanitizing in dev mode.#8546

Merged
mprobst merged 1 commit intoangular:masterfrom
mprobst:log-sanitizer-issues
May 10, 2016
Merged

feat(security): warn users when sanitizing in dev mode.#8546
mprobst merged 1 commit intoangular:masterfrom
mprobst:log-sanitizer-issues

Conversation

@mprobst
Copy link
Copy Markdown
Contributor

@mprobst mprobst commented May 9, 2016

This should help developers to figure out what's going on when the sanitizer
strips some input.

Fixes #8522.

This should help developers to figure out what's going on when the sanitizer
strips some input.

Fixes angular#8522.
@mprobst
Copy link
Copy Markdown
Contributor Author

mprobst commented May 9, 2016

@rjamet could you review?

@mprobst mprobst added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 9, 2016
@rjamet
Copy link
Copy Markdown
Contributor

rjamet commented May 9, 2016

LGTM. Looks like you've taken the canonicalization of HTML into account, which was my main concern with this thing.

@mprobst mprobst merged commit 3e68b7e into angular:master May 10, 2016
@mprobst mprobst added pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 10, 2016
@mprobst mprobst deleted the log-sanitizer-issues branch May 26, 2016 16:46
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(SanitizationService): warn the user when sanitization prevents binding

3 participants