feat(@ngtools/webpack): add AngularCompilerPlugin#7512
feat(@ngtools/webpack): add AngularCompilerPlugin#7512filipesilva wants to merge 2 commits intoangular:masterfrom
Conversation
5f67849 to
2adf521
Compare
package.json
Outdated
| "stylus": "^0.54.5", | ||
| "stylus-loader": "^3.0.1", | ||
| "typescript": "~2.4.2", | ||
| "typescript": "^2.3.2", |
There was a problem hiding this comment.
We don't want to unlock typescript. There's no guarantee our stuff will work with TS 2.6
There was a problem hiding this comment.
This was needed to test a linked AIO since it isn't ts 2.4 ready. Will remove before PR is done.
1afe042 to
31bcf9b
Compare
31bcf9b to
cff6234
Compare
bf9f231 to
2475383
Compare
2475383 to
a2fc994
Compare
| } | ||
|
|
||
| enum Platform { | ||
| browser, |
There was a problem hiding this comment.
Please capitalize enum names.
|
Only other comment would be to have this on by default when the user uses AOT and Angular 5. |
|
I would see 3 paths here:
1 and 3 should be part of this PR, while 2 should be a separate PR. |
898d5d8 to
3270909
Compare
3270909 to
ad9b46b
Compare
| default: buildConfigDefaults['namedChunks'] | ||
| }, | ||
| { | ||
| name: 'experimental-angular-compiler', |
There was a problem hiding this comment.
I thought we were getting rid of this by using a version check.
There was a problem hiding this comment.
Nevermind, that will happen once we have JIT support.
| } | ||
|
|
||
| enum PLATFORM { | ||
| browser, |
|
|
||
| cache: | ||
| - node_modules | ||
| - node_modules -> package-lock.json |
There was a problem hiding this comment.
What does the package-lock.json means here?
There was a problem hiding this comment.
It's how that cache gets invalidated, I was having trouble with this PR in appveyour and had to invalidate it properly.
| @@ -0,0 +1,114 @@ | |||
| import * as ts from 'typescript'; | |||
There was a problem hiding this comment.
Unittests for this file? It's quite sensitive code that I'd like to avoid regressions.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.