This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat($browser): add expires to cookies() method#5056
Closed
erubboli wants to merge 6 commits intoangular:masterfrom
Closed
feat($browser): add expires to cookies() method#5056erubboli wants to merge 6 commits intoangular:masterfrom
erubboli wants to merge 6 commits intoangular:masterfrom
Conversation
Contributor
|
This is a subset of #2459 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a new optional parameter to the cookies() method to allow the expire date to be explicit. Please note the test cannot check the expire date so the only way to test is to check its validity if its set in the past or in the future. If you have a better idea on how to test it I can improve it.