Skip to content

Set up builder/schematic in package.json#2053

Merged
jamesdaniels merged 1 commit intoangular:feature/ng-deployfrom
kirjs:feature/ng-deploy
Apr 24, 2019
Merged

Set up builder/schematic in package.json#2053
jamesdaniels merged 1 commit intoangular:feature/ng-deployfrom
kirjs:feature/ng-deploy

Conversation

@NothingEverHappens
Copy link
Copy Markdown
Contributor

@NothingEverHappens NothingEverHappens commented Apr 24, 2019

Make sure everything works 🔥

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

@kirjs
Set up builder/schematic in package.json
f410687 
Make sure everything works 🔥
@googlebot
Copy link
Copy Markdown

googlebot commented Apr 24, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Copy Markdown

googlebot commented Apr 24, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@jamesdaniels jamesdaniels merged commit b36f972 into angular:feature/ng-deploy Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: no

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NothingEverHappens @googlebot @jamesdaniels @kirjs