Merged
Conversation
Member
Author
|
@jhuleatt Here are the |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Publishing |
Member
Author
|
I'm happy with this build, cutting as |
markgoho
approved these changes
May 26, 2019
jhuleatt
reviewed
May 30, 2019
No longer need to add all the deps and stuff in each package.json, simplify all this. Also indicate side effects for webpack to do it's thing. Pack after build too.
Member
Author
|
Cut |
Member
Author
|
Cutting |
Member
Author
|
FYI I've ported https://onsnapshot.com/ and everything is working great! https://github.com/jamesdaniels/onsnapshot |
Member
Author
|
Also I've had a bunch of people experimenting with the RCs here #2086 |
peterennis
added a commit
to peterennis/angularfire2
that referenced
this pull request
Jun 1, 2019
chore(): final fixes for 5.2.0 release (angular#2085)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR serves as my working changes to 5.2 before release.
traceLastis deceiving, as if there is time between the last emission and completion that time is counted. Name ittraceUntilCompleteinstead.traceWhilewas just an opposite oftraceUntilwhich doesn't do it's name justice. I've since super charged it,traceWhilewill trace starting with an emission that passes the test and ending with the first failure. It will also produce multiple traces, e.g,of(false, true, false, true, true, false).pipe(traceWhile('while', a => a))will produce traces for the time between the 2nd and 3rd emission and the 4th and 6th emissions. Imagine it's use in a game loop:traceWhile('timePlaying', state => state.isPlaying && !state.isGameOver)orCompleteoptions totraceUntilandtraceWhile^^^^^^^^^^!traceCompletehas to be afterfirstasisStableitself is not completingAngularFirePerformancewas not eagerly initializing performance monitoringAngularFirePerformanceng addstepng addmore forgiving if they already have a.firebasercorfirebase.jsonAngularFirePerformancelazy and replacing dynamic import withempty()in the UMDfirebase/messagingwithempty()in the UMD, fixes AngularFireMessaging keeps Universal from compiling #1938