Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

docs(eol): update docs website for End-of-Life#12153

Merged
Splaktar merged 1 commit intomasterfrom
website-updates-for-eol
Mar 22, 2022
Merged

docs(eol): update docs website for End-of-Life#12153
Splaktar merged 1 commit intomasterfrom
website-updates-for-eol

Conversation

@Splaktar
Copy link
Copy Markdown
Contributor

@Splaktar Splaktar commented Mar 8, 2022 •
edited
Loading

PR Checklist

Please check your PR fulfills the following requirements:

  • Does this PR fix a regression since 1.2.0, a security flaw, or a problem caused by a new browser version?
  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[x] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

What is the new behavior?

  • fix alignment of text in banner
  • update home page for EOL
  • update banner messaging for EOL
  • update SECURITY.md for EOL
  • update package-lock.json to v2
  • add path-type devDependency required by cssnano
  • fix resolutions for npm-force-resolutions to remove ^ and ~ that can break w/ npm v8
  • update karma to fix log4js vulnerability
  • add cliui devDependency required by karma

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Related to

cc: @mgol @mgechev @gkalpak @aaronfrost

@Splaktar Splaktar self-assigned this Mar 8, 2022
@Splaktar Splaktar added the P1: urgent Urgent issues that should be addressed in the next minor or patch release. label Mar 8, 2022
@Splaktar Splaktar added this to the 1.2.5 milestone Mar 8, 2022
@Splaktar Splaktar requested a review from jelbourn March 8, 2022 19:40
@Splaktar Splaktar force-pushed the website-updates-for-eol branch 2 times, most recently from dca3171 to 591f4e5 Compare March 8, 2022 20:17
jelbourn
jelbourn reviewed Mar 10, 2022
View reviewed changes
@Splaktar
docs(eol): update docs website for End-of-Life
a0101ac 
- fix alignment of text in banner
- update home page for EOL
- update banner messaging for EOL
- update `SECURITY.md` for EOL
- update `package-lock.json` to v2
- add `path-type` devDependency required by cssnano
- fix resolutions for npm-force-resolutions to remove ^ and ~ that can break w/ npm v8
- update karma to fix log4js vulnerability
- add `cliui` devDependency required by karma
@Splaktar Splaktar force-pushed the website-updates-for-eol branch from 591f4e5 to a0101ac Compare March 10, 2022 06:54
@Splaktar Splaktar requested a review from jelbourn March 10, 2022 07:04
@Splaktar
Copy link
Copy Markdown
Contributor Author

Splaktar commented Mar 10, 2022

Review feedback addressed.

jelbourn
jelbourn approved these changes Mar 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar merged commit bfc8ae7 into master Mar 22, 2022
@Splaktar Splaktar deleted the website-updates-for-eol branch March 22, 2022 15:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jelbourn jelbourn jelbourn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Splaktar Splaktar

Labels

P1: urgent Urgent issues that should be addressed in the next minor or patch release.

Projects

None yet

Milestone

1.2.5

Development

Successfully merging this pull request may close these issues.

2 participants

@Splaktar @jelbourn