Open
Conversation
efantinatti
suggested changes
Dec 24, 2024
efantinatti
left a comment
There was a problem hiding this comment.
Dear Anis Bouazra
Session 1:
1 - OK.
Session 2:
2 - OK.
Session 3:
3 - Missing the whole session. Check it out.
Final:
4 - Check the aforementioned points prior to merging your feature branch 'assignment-two' to 'main'.
Mark: 60 points.
Owner
Author
@efantinatti Thank you for your feedback. Somehow, my answer to part 3 was not included in my initial pull request. I have added it to the updated pull request, and I hope you can still consider it in your assessment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
I discovered better ways to optimize SQL queries, specifically in grouping and filtering data for more precise analysis.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Yes, I considered using window functions instead of subqueries for certain aggregations to simplify the query logic.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
one challenge was structuring queries to handle scenarios like selecting the highest and lowest sales using UNION while ensuring compatibility with database limitations, such as the proper use of LIMIT within a UNION
How were these changes tested?
The changes were tested using sample data sets
A reference to a related issue in your repository (if applicable)
Checklist