Open
Conversation
juliagallucci
suggested changes
May 5, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
Code is functional, but it could be simplified using fewer lines with sorted() and string methods. Please revise
…d string functions and making the code shorter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
A: Adding code to solve assignment-1 questions
What did you learn from the changes you have made?
A: How to use list methods and string functions to solve problems.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
A: Yes, I through of using list comprehension to achieve the same. But, that has not been covered in the class yet. Additionally, that methods is it more complex. So, I used the most basic and simple operations to accomplish the task.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
A: Case insensitivity/sensitivity was a hard. But I used a neat trick, which is to convert the entire string into on case and then sorting for comparisons.
How were these changes tested?
A: I checked the answers visually.
A reference to a related issue in your repository (if applicable)
A: not applicable
Checklist