Open
Conversation
anjali-deshpande-hub
suggested changes
May 12, 2025
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Looks good! Just one change:
Change "python/05_src/data/assignment_2_data/inflammation_01.csv" to relative path "../../05_src/data/assignment_2_data/inflammation_01.csv". That way learning support will also be able to run the code.
Remove hardcoded path variable root_dir "/home/anup/goofy/careers/DSI_course_toronto/assignments/" . You can simply use all_paths variable instead of os.path.join(root_dir,all_paths[0]) everywhere.
Owner
Author
|
Thanks @anjali-deshpande-hub, I have made the correction to the codes. Looking forward to your next review. Anup |
anjali-deshpande-hub
approved these changes
May 13, 2025
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
All review changes done successfully. Well done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code to complete the tasks of Python assignment-2
What did you learn from the changes you have made?
How to read CSV files, looping, flow control, numpy operations etc.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
The file paths of the CSV files needs to be changed to reflect my directory structure. I used path.join function from Python's os module to add the root directory to the CSV filename. This made it easier to work with as I didn't have to change each CSV file path independently.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
No, this assignment was pretty easy.
How were these changes tested?
I called the function and verified the output. For ex, CSV file from all_lists[2] has a row (last one) with all zero entries. This way, I checked for both cases of the function output.
A reference to a related issue in your repository (if applicable)
Not applicable.
Checklist