Skip to content

Improvement: support full absolute URLs without base path joining (closes #79)#80

Merged
manggit merged 2 commits intoanvilco:masterfrom
paulchino:issue-79/request_rest_improvement
Apr 29, 2025
Merged

Improvement: support full absolute URLs without base path joining (closes #79)#80
manggit merged 2 commits intoanvilco:masterfrom
paulchino:issue-79/request_rest_improvement

Conversation

@paulchino
Copy link
Copy Markdown

@paulchino paulchino commented Apr 26, 2025

Closes #79

Description

This PR addresses Issue #79 where passing a fully-qualified URL to request_rest.get() or request_rest.post() would incorrectly prepend the base URL, resulting in an invalid request.

Changes

  • Added absolute_url option to BaseAnvilHttpRequest.get() and post() methods.
  • Updated _request method to respect absolute_url flag.
  • Tests for get and post that verify both relative paths and absolute URLs are handled correctly.

@paulchino paulchino marked this pull request as ready for review April 26, 2025 22:50
@paulchino paulchino changed the title Fix request_rest to support absolute URLs (closes #79) fix(request_rest): support full absolute URLs without base path joining (closes #79) Apr 26, 2025
@paulchino paulchino changed the title fix(request_rest): support full absolute URLs without base path joining (closes #79) Improvement: support full absolute URLs without base path joining (closes #79) Apr 26, 2025
@manggit manggit merged commit 63bbd28 into anvilco:master Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

request_rest improvement

2 participants