Skip to content

cks: prevent npe on cluster listing with removed offering#10075

Merged
DaanHoogland merged 1 commit intoapache:4.19from
shapeblue:fix-npe-listk8s
Jan 24, 2025
Merged

cks: prevent npe on cluster listing with removed offering#10075
DaanHoogland merged 1 commit intoapache:4.19from
shapeblue:fix-npe-listk8s

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Dec 10, 2024

Description

NPE discussed in #10074

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (ef1a58d) to head (ba7eb54).
Report is 43 commits behind head on 4.19.

Files with missing lines Patch % Lines
...bernetes/cluster/KubernetesClusterManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #10075      +/-   ##
============================================
- Coverage     15.12%   15.12%   -0.01%     
- Complexity    11255    11257       +2     
============================================
  Files          5408     5408              
  Lines        473838   473843       +5     
  Branches      57770    57771       +1     
============================================
- Hits          71676    71671       -5     
- Misses       394165   394175      +10     
  Partials       7997     7997
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.84% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Dec 10, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Dec 10, 2024

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland added this to the 4.19.2 milestone Dec 10, 2024
DaanHoogland
DaanHoogland approved these changes Dec 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, seems to do what is needed

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Dec 10, 2024

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11771

weizhouapache
weizhouapache approved these changes Dec 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Dec 10, 2024

line 564 to 566 were added in #7515, it should fix #10074
this pr is also good to have

@vladimirpetrov vladimirpetrov self-assigned this Jan 22, 2025
vladimirpetrov
vladimirpetrov approved these changes Jan 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@vladimirpetrov vladimirpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on manual testing.

@vladimirpetrov vladimirpetrov removed their assignment Jan 24, 2025
@DaanHoogland DaanHoogland merged commit 4787885 into apache:4.19 Jan 24, 2025
@DaanHoogland DaanHoogland deleted the fix-npe-listk8s branch January 24, 2025 08:47
rg9975 pushed a commit to rg9975/cloudstack that referenced this pull request Jan 31, 2025
@shwstppr
cks: prevent npe on cluster listing with removed offering (apache#10075)
5e59493 
Signed-off-by: Abhishek Kumar <[email protected]>
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@shwstppr @dhslove
cks: prevent npe on cluster listing with removed offering (apache#10075)
a4ae988 
Signed-off-by: Abhishek Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@vladimirpetrov vladimirpetrov vladimirpetrov approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

component:kubernetes

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

6 participants

@shwstppr @blueorangutan @weizhouapache @yadvr @DaanHoogland @vladimirpetrov