Skip to content

Improve logs for VM migrations#12332

Merged
DaanHoogland merged 2 commits intoapache:4.22from
shapeblue:422-improve-migrationlogs
Jan 9, 2026
Merged

Improve logs for VM migrations#12332
DaanHoogland merged 2 commits intoapache:4.22from
shapeblue:422-improve-migrationlogs

Conversation

@nvazquez
Copy link
Contributor

@nvazquez nvazquez commented Dec 24, 2025

Description

This PR adds more comprehensive logs to the VM migration flow

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@nvazquez
Copy link
Contributor Author

nvazquez commented Dec 24, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Dec 24, 2025

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Dec 24, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 11.42857% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.59%. Comparing base (55ab7c5) to head (d57e3ac).
⚠️ Report is 23 commits behind head on 4.22.

Files with missing lines Patch % Lines
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java 0.00% 21 Missing ⚠️
...resource/wrapper/LibvirtMigrateCommandWrapper.java 37.50% 5 Missing ⚠️
...pper/LibvirtPrepareForMigrationCommandWrapper.java 25.00% 3 Missing ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##               4.22   #12332    +/-   ##
==========================================
  Coverage     17.59%   17.59%            
- Complexity    15595    15597     +2     
==========================================
  Files          5910     5910            
  Lines        529606   529718   +112     
  Branches      64705    64716    +11     
==========================================
+ Hits          93178    93206    +28     
- Misses       425940   426021    +81     
- Partials      10488    10491     +3
Flag Coverage Δ
uitests 3.57% <ø> (+<0.01%) ⬆️
unittests 18.66% <11.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

blueorangutan commented Dec 24, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16147

DaanHoogland
DaanHoogland approved these changes Dec 24, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, just some nitpicking

abh1sar
abh1sar approved these changes Jan 2, 2026
View reviewed changes
Copy link
Contributor

@abh1sar abh1sar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@nvazquez
Copy link
Contributor Author

nvazquez commented Jan 8, 2026

@blueorangutan test

@nvazquez nvazquez added this to the 4.22.1 milestone Jan 8, 2026
@blueorangutan
Copy link

blueorangutan commented Jan 8, 2026

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sureshanaparti
sureshanaparti approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@sureshanaparti sureshanaparti moved this to In Progress in Apache CloudStack 4.22.1 Jan 8, 2026
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 8, 2026

I think we can settle for regression tests on this one.

@blueorangutan
Copy link

blueorangutan commented Jan 8, 2026

[SF] Trillian test result (tid-15138)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55790 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12332-t15138-kvm-ol8.zip
Smoke tests completed. 147 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_scale_kubernetes_cluster Failure 31.98 test_kubernetes_clusters.py
test_02_ssl_offloading_project_vpc Failure 288.60 test_ssl_offloading.py

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 9, 2026

[SF] Trillian test result (tid-15138) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 55790 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12332-t15138-kvm-ol8.zip Smoke tests completed. 147 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_scale_kubernetes_cluster Failure 31.98 test_kubernetes_clusters.py
test_02_ssl_offloading_project_vpc Failure 288.60 test_ssl_offloading.py

@nvazquez , can you check if these are migration related?

@nvazquez
Copy link
Contributor Author

nvazquez commented Jan 9, 2026

Hi @DaanHoogland I have checked them and are not related to migrations

@DaanHoogland DaanHoogland merged commit 04875f1 into apache:4.22 Jan 9, 2026
25 of 26 checks passed
@sureshanaparti sureshanaparti deleted the 422-improve-migrationlogs branch January 12, 2026 07:18
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jan 21, 2026
@nvazquez @dhslove
Improve logs for VM migrations (apache#12332)
799578e
sandeeplocharla pushed a commit to NetApp/cloudstack that referenced this pull request Feb 6, 2026
@nvazquez
Improve logs for VM migrations (apache#12332)
19a608d
@nvazquez nvazquez mentioned this pull request Mar 24, 2026
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@abh1sar abh1sar abh1sar approved these changes

@kiranchavala kiranchavala Awaiting requested review from kiranchavala

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

Assignees

No one assigned

Labels

component:compute component:kvm component:logging component:orchestration status:waiting-for-smoketest-results type:enhancement

Projects

Apache CloudStack 4.22.1
Status: In Progress

Milestone

4.22.1

Development

Successfully merging this pull request may close these issues.

5 participants

@nvazquez @blueorangutan @DaanHoogland @sureshanaparti @abh1sar