Multiple SSH Keys support by davidjumani · Pull Request #5965 · apache/cloudstack

davidjumani · 2022-02-08T10:49:36Z

Description

Is a continuation of #5215
The result of the GSoC project
Adds support for multiple SSH Keys for VMs.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

Major
Minor

Screenshots (if appropriate):

… the resetvmsshinternal, and added in details

davidjumani · 2022-02-23T10:26:40Z

@davidjumani code looks good to me. tested ok.

I have few questions or suggestions

(1) for existing vms which has SSH.PublicKey in user_vm_details before cloudstack upgrade, would be good to add a record SSH.KeyPairNames in the table ?

(2) the URL of ssh keypair page is http://localhost:5050/#/ssh/. What if there are multiple ssh keypairs with same name on the platform ? uuid looks better than ssh keypair name.

(3) on UI, can the existing ssh keypair be checked by default when open the dialog of reset ssh keypair ?

I've addressed points 1 & 3 in this PR. Point 2 might require a larger change since the uuid field was recently added to ssh keyparis

blueorangutan · 2022-02-23T10:40:53Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2698

davidjumani · 2022-02-23T11:00:49Z

@blueorangutan test

blueorangutan · 2022-02-23T11:01:03Z

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-02-23T21:33:47Z

Trillian test result (tid-3420)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36647 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5965-t3420-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

davidjumani · 2022-02-24T04:53:01Z

@blueorangutan package

blueorangutan · 2022-02-24T04:54:03Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-24T05:33:07Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2706

davidjumani · 2022-02-24T05:33:50Z

@blueorangutan test

blueorangutan · 2022-02-24T05:34:04Z

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

weizhouapache

thanks @davidjumani

I have tested this again, everything looks good.
cc @nvazquez

blueorangutan · 2022-02-24T18:37:44Z

Trillian test result (tid-3428)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45704 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5965-t3428-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_07_deploy_kubernetes_ha_cluster	`Failure`	3622.52	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.07	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	69.29	test_kubernetes_clusters.py

weizhouapache · 2022-02-25T11:06:49Z

Trillian test result (tid-3428) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45704 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5965-t3428-kvm-centos7.zip Smoke tests completed. 91 look OK, 1 have errors Only failed tests results shown below:

Test Result Time (s) Test File
test_07_deploy_kubernetes_ha_cluster Failure 3622.52 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.07 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 69.29 test_kubernetes_clusters.py

@davidjumani
this needs more investigation.

might it be caused by systemvm template /cloud-init ?

andrijapanicsb · 2022-02-25T11:34:40Z

LGTM, tested briefly and it looks good.

davidjumani · 2022-02-26T15:24:11Z

@weizhouapache Seems unrelated. I'll kick the tests again

davidjumani · 2022-02-26T15:24:18Z

@blueorangutan test

blueorangutan · 2022-02-26T15:25:03Z

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-02-27T01:47:55Z

Trillian test result (tid-3444)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35994 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5965-t3444-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py

davidjumani · 2022-02-28T03:52:49Z

@blueorangutan package

blueorangutan · 2022-02-28T03:54:03Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-28T04:35:10Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2727

davidjumani · 2022-02-28T04:35:29Z

@blueorangutan test

blueorangutan · 2022-02-28T04:36:03Z

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-02-28T13:47:36Z

Trillian test result (tid-3446)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31716 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5965-t3446-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

bicrxm added 30 commits July 2, 2021 13:49

keypairs added in api-constants

cf2e27a

names parameter added

ac655fe

findbynames method added in dao

2c7404f

change in impl to find and reset multiple keys

4cdd371

findbynames method implemented

274ab95

Merge branch 'main' of https://github.com/apache/cloudstack

17c40a5

log the publickeys, check the ssh keys given exists or not

4d8f56e

new ArrayList<>

65029d9

Merge branch 'main' of https://github.com/apache/cloudstack

0f7a274

SQL IN toArray

00e2634

keypair

33b8bd8

null pointer exception solved with + concatanation

055e8b3

null pointer exception solved with + concatanation

fb0dce9

error resolved

3b13ab7

keypair name to names in uservmresponse

f271ab5

keypair name is set in the uservmresponse, from the details

2621b67

Merge branch 'apache:main' into main

55fb578

null checks are removed, keypairnames are stored in a string, sent to…

0f2ffdb

… the resetvmsshinternal, and added in details

Merge branch 'main' of https://github.com/apache/cloudstack

13b78f2

Merge https://github.com/bicrxm/cloudstack

2f15af7

commit first eval

689f824

Merge branch 'apache:main' into main

264a4f1

deploy vm takes multiple ssh-keys

48be6cf

Merge branch 'main' of https://github.com/bicrxm/cloudstack into main

10d3d76

Merge branch 'apache:main' into main

31065ba

Deploy VM UI changed to accept multiple ssh keys

748b624

Merge branch 'main' of https://github.com/bicrxm/cloudstack into main

4be4c93

Merge branch 'apache:main' into main

623cafd

Reset SSH UI API changed

24bdc35

ResetSSH.vue

7357d7a

nvazquez requested a review from weizhouapache February 24, 2022 03:00

get keys from the right account

754f3f0

weizhouapache approved these changes Feb 24, 2022

View reviewed changes

nvazquez marked this pull request as draft February 24, 2022 11:49

Merge branch 'main' of github.com:apache/cloudstack into mul-ssh-keys

b8a6174

davidjumani marked this pull request as ready for review February 28, 2022 08:08

nvazquez merged commit 85c5997 into apache:main Mar 2, 2022

Conversation

davidjumani commented Feb 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale

Screenshots (if appropriate):

Uh oh!

davidjumani commented Feb 23, 2022

Uh oh!

blueorangutan commented Feb 23, 2022

Uh oh!

davidjumani commented Feb 23, 2022

Uh oh!

blueorangutan commented Feb 23, 2022

Uh oh!

blueorangutan commented Feb 23, 2022

Uh oh!

davidjumani commented Feb 24, 2022

Uh oh!

blueorangutan commented Feb 24, 2022

Uh oh!

blueorangutan commented Feb 24, 2022

Uh oh!

davidjumani commented Feb 24, 2022

Uh oh!

blueorangutan commented Feb 24, 2022

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Feb 24, 2022

Uh oh!

weizhouapache commented Feb 25, 2022

Uh oh!

andrijapanicsb commented Feb 25, 2022

Uh oh!

davidjumani commented Feb 26, 2022

Uh oh!

davidjumani commented Feb 26, 2022

Uh oh!

blueorangutan commented Feb 26, 2022

Uh oh!

blueorangutan commented Feb 27, 2022

Uh oh!

davidjumani commented Feb 28, 2022

Uh oh!

blueorangutan commented Feb 28, 2022

Uh oh!

blueorangutan commented Feb 28, 2022

Uh oh!

davidjumani commented Feb 28, 2022

Uh oh!

blueorangutan commented Feb 28, 2022

Uh oh!

blueorangutan commented Feb 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

davidjumani commented Feb 8, 2022 •

edited

Loading