Tokenize empty line comments correctly#2161
Merged
iffyio merged 1 commit intoapache:mainfrom Jan 13, 2026
Merged
Conversation
MySQL likes to send "blocky" comments where a line comment is surrounded by empty comments, like so: ``` -- -- Table structure for table `foo` -- CREATE TABLE ... ``` Currently, these comments are tokenized as MINUS, MINUS instead of an empty line comment. This commits fixes this problem by accepting any kind of whitespace to delimit a line comment.
iffyio
approved these changes
Jan 13, 2026
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Feb 3, 2026
fmguerreiro
pushed a commit
to fmguerreiro/datafusion-sqlparser-rs
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL likes to send "blocky" comments where a line comment is surrounded by empty comments, like so:
Currently, these comments are tokenized as MINUS, MINUS instead of an empty line comment.
This commits fixes this problem by accepting any kind of whitespace to delimit a line comment.