Support Order of OFFSET and LIMIT#385
Closed
yuval-illumex wants to merge 7 commits intoapache:mainfrom
Closed
Conversation
Contributor
|
Note these is a similar PR from @QuantumBear #370 |
Pull Request Test Coverage Report for Build 1607242568
💛 - Coveralls |
OFFSET and LIMIT
alamb
reviewed
Feb 5, 2022
| } else { | ||
| None | ||
| }; | ||
| for _x in 0..2 { |
Contributor
There was a problem hiding this comment.
as written this will also parse LIMIT LIMIT and OFFSET OFFSET I think.
alamb
reviewed
Feb 5, 2022
Contributor
alamb
left a comment
There was a problem hiding this comment.
As I don't have permissions to fix this PR, I made a new one based on this change: #413
Thanks for the contribution @yuval-illumex and I am sorry for the delay in reviewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #384
Support OFFSET LIMIT and LIMIT OFFSET