Skip to content

FINERACT-2455: Working Capital product near breach configuration#5740

Merged
adamsaghy merged 2 commits intoapache:developfrom
openMF:FINERACT-2455/working-capital-product-near-breach-configuration
Apr 24, 2026
Merged

FINERACT-2455: Working Capital product near breach configuration#5740
adamsaghy merged 2 commits intoapache:developfrom
openMF:FINERACT-2455/working-capital-product-near-breach-configuration

Conversation

@alberto-art3ch
Copy link
Copy Markdown
Contributor

@alberto-art3ch alberto-art3ch commented Apr 6, 2026

Description

User should be able to configure near breach at the product level(similar to Breach configuration), now with the next attributes:

  • Near Breach Threshold (% field)
  • Near Breach Evaluation Frequency
  • Near Breach Evaluation Frequency Type (DAYS, MONTHS, YEARS)

FINERACT-2455

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2455/working-capital-product-near-breach-configuration branch 5 times, most recently from a6f5a4d to 3f5d710 Compare April 8, 2026 05:05
@adamsaghy
Copy link
Copy Markdown
Contributor

adamsaghy commented Apr 8, 2026

@alberto-art3ch please rebase

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2455/working-capital-product-near-breach-configuration branch from 3f5d710 to a8de8ab Compare April 9, 2026 01:02
@alberto-art3ch
Copy link
Copy Markdown
Contributor Author

alberto-art3ch commented Apr 9, 2026

@alberto-art3ch please rebase

Done! Please review

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2455/working-capital-product-near-breach-configuration branch 2 times, most recently from cfc10f4 to 21f037c Compare April 9, 2026 18:29
galovics
galovics requested changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@galovics galovics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds are failing, pls fix them.

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2455/working-capital-product-near-breach-configuration branch from 21f037c to 726b5bc Compare April 9, 2026 20:18
@alberto-art3ch
Copy link
Copy Markdown
Contributor Author

alberto-art3ch commented Apr 9, 2026

Builds are failing, pls fix them.

Done! Please review

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2455/working-capital-product-near-breach-configuration branch from 726b5bc to e956b9a Compare April 10, 2026 18:43
@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2455/working-capital-product-near-breach-configuration branch 2 times, most recently from 5ec60de to e4b878b Compare April 15, 2026 03:03
@galovics
Copy link
Copy Markdown
Contributor

galovics commented Apr 15, 2026

@alberto-art3ch conflicting, can you rebase pls?

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2455/working-capital-product-near-breach-configuration branch from e4b878b to 02280a9 Compare April 15, 2026 12:51
@alberto-art3ch
Copy link
Copy Markdown
Contributor Author

alberto-art3ch commented Apr 15, 2026

@alberto-art3ch conflicting, can you rebase pls?

Done! rebase applied and conflicts solved

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2455/working-capital-product-near-breach-configuration branch 3 times, most recently from fd2e22a to 07f4413 Compare April 15, 2026 21:57
budaidev
budaidev requested changes Apr 16, 2026
View reviewed changes
Comment thread ...es/db/changelog/tenant/module/workingcapitalloan/parts/0028_wc_near_breach_configuration.xml Outdated
Comment thread ...es/db/changelog/tenant/module/workingcapitalloan/parts/0028_wc_near_breach_configuration.xml Outdated
Comment thread ...es/db/changelog/tenant/module/workingcapitalloan/parts/0028_wc_near_breach_configuration.xml Outdated
Comment thread ...es/db/changelog/tenant/module/workingcapitalloan/parts/0028_wc_near_breach_configuration.xml Outdated
Comment thread ...portfolio/workingcapitalloanbreach/service/WorkingCapitalBreachWritePlatformServiceImpl.java Outdated
Comment thread ...ortfolio/workingcapitalloanproduct/serialization/WorkingCapitalLoanProductDataValidator.java Outdated
Comment thread ...rc/test/java/org/apache/fineract/integrationtests/WorkingCapitalLoanApplicationCRUDTest.java Outdated
Comment thread ...ts/src/test/java/org/apache/fineract/integrationtests/WorkingCapitalLoanProductCRUDTest.java Outdated
Comment thread ...t/portfolio/workingcapitalloan/serialization/WorkingCapitalLoanApplicationDataValidator.java Outdated
Comment thread ...ache/fineract/portfolio/workingcapitalloan/domain/WorkingCapitalLoanPeriodFrequencyType.java Outdated
@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2455/working-capital-product-near-breach-configuration branch 2 times, most recently from 4891306 to 686b771 Compare April 16, 2026 22:46
@alberto-art3ch
Copy link
Copy Markdown
Contributor Author

alberto-art3ch commented Apr 16, 2026

@budaidev Change requested done, except the first about partial validation, I think is valid your comment but we need to define the right validation

@adamsaghy adamsaghy requested a review from budaidev April 17, 2026 10:42
@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2455/working-capital-product-near-breach-configuration branch 4 times, most recently from a81da7f to c8b10f8 Compare April 23, 2026 04:50
@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-2455/working-capital-product-near-breach-configuration branch from c8b10f8 to 4a738a7 Compare April 23, 2026 12:41
@adamsaghy adamsaghy force-pushed the FINERACT-2455/working-capital-product-near-breach-configuration branch from 4a738a7 to 3022891 Compare April 23, 2026 12:59
@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2455/working-capital-product-near-breach-configuration branch 4 times, most recently from 6771ee2 to cabd7db Compare April 24, 2026 04:57
@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-2455/working-capital-product-near-breach-configuration branch from cabd7db to cf91c5f Compare April 24, 2026 12:48
@adamsaghy adamsaghy merged commit 408ae23 into apache:develop Apr 24, 2026
57 of 58 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2455/working-capital-product-near-breach-configuration branch April 24, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsaghy adamsaghy adamsaghy left review comments

@galovics galovics galovics requested changes

@budaidev budaidev Awaiting requested review from budaidev

+1 more reviewer

@oleksii-novikov-onix oleksii-novikov-onix oleksii-novikov-onix approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alberto-art3ch @adamsaghy @galovics @oleksii-novikov-onix @budaidev @MarianaDmytrivBinariks