Skip to content

Fix clickhouse0.3.2 plugin executeBatch method #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wulangcode wants to merge 2 commits into from
Closed

Fix clickhouse0.3.2 plugin executeBatch method #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04a46a7
Fix clickhouse0.3.2 plugin executeBatch method
wulangcode Mar 3, 2023
3cd175e
Fix clickhouse0.3.2 plugin executeBatch method
wulangcode Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Release Notes.
* Fix servicecomb plugin trace break.
* Adapt Armeria's plugins to the latest version 1.22.x
* Fix tomcat-10x-plugin and add test case to support tomcat7.x-8.x-9.x.
* Fix clickhouse0.3.2 plugin executeBatch method

#### Documentation
* Update docs of Tracing APIs, reorganize the API docs into six parts.
Expand Down
2 changes: 1 addition & 1 deletion ...a/org/apache/skywalking/apm/plugin/jdbc/clickhouse/v32/SWClickHousePreparedStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ public void clearBatch() throws SQLException {

@Override
public int[] executeBatch() throws SQLException {
return PreparedStatementTracing.execute(realStatement, connectInfo, "executeBatch", "", new PreparedStatementTracing.Executable<int[]>() {
return PreparedStatementTracing.execute(realStatement, connectInfo, "executeBatch", sql, new PreparedStatementTracing.Executable<int[]>() {
@Override
public int[] exe(PreparedStatement realStatement, String sql) throws SQLException {
return realStatement.executeBatch();
Expand Down
2 changes: 1 addition & 1 deletion ...a/org/apache/skywalking/apm/plugin/jdbc/clickhouse/SWClickHousePreparedStatementTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ public void testBatch() throws SQLException, MalformedURLException {
TraceSegment traceSegment = segmentStorage.getTraceSegments().get(0);
List<AbstractTracingSpan> spans = SegmentHelper.getSpans(traceSegment);
assertThat(spans.size(), is(1));
assertDBSpan(spans.get(0), "ClickHouse/JDBC/PreparedStatement/executeBatch", "");
assertDBSpan(spans.get(0), "ClickHouse/JDBC/PreparedStatement/executeBatch", "UPDATE test SET a = ? WHERE b = ?");

}

Expand Down