Fix problem in the jetty-client-9.x which leading original listener reading empty content#703
Fix problem in the jetty-client-9.x which leading original listener reading empty content#703Colin-debugIO wants to merge 2 commits intoapache:mainfrom
Conversation
|
|
||
| <properties> | ||
| <jetty-client.version>9.1.0.v20131115</jetty-client.version> | ||
| <jetty-client.version>9.4.55.v20240627</jetty-client.version> |
There was a problem hiding this comment.
Why change this? Would this break preview compatibility?
There was a problem hiding this comment.
because org.eclipse.jetty.client.api.Response.AsyncContentListener cound not be found in 9.1.x version
if the wrapper not implementing it, application will also get empty result when using jetty client 9.2.x or later,
by testing, it is compatible with preview version 9.1.0.v20131115
, 9.2.12.v20150709, 9.3.30.v20211001 and 9.4.55.v20240627
There was a problem hiding this comment.
If it doesn't exist in 9.1.0.v20131115, how do we make sure of compatibility? This doesn't make sense.
|
You should fix CI, and add more versions of newly supported to verify. |
|
You should update the following test scenarios and expected files. add the async calling as you mentioned. |
|
@mei-zengxin Are you still working on this? |
|
Close as no update. |
Fix problem in the jetty-client-9.x which leading original listener reading empty content
when using jetty-client 9.x send async request, reponse body is always empty
because the onContent callback could not be executed
CHANGESlog.