composer.json (2)

55-55: Call out behavior changes as breaking (spatial filters, 4xx codes).

Per the related test updates, this DB bump changes spatial semantics (e.g., removed “contains on line” test) and error handling (e.g., invalid point → 400). Treat this as a breaking change: add migration notes, update API docs, and highlight in the PR description and release notes to avoid downstream surprises.

Would you like me to draft a short migration section summarizing the spatial changes and expected HTTP responses?

---

55-55: composer.lock pins the dev alias — add prefer-stable if this is temporary

• composer.lock pins utopia-php/database to dev-spatial-filter (ref 753800f9eb16bfd62b9647a0c54f39675dde728b); ensure composer.lock is committed in this PR.
• composer.json still contains the dev alias at line 55 and has no minimum-stability/prefer-stable set — add "config": { "prefer-stable": true } if you intend to keep dev constraints temporarily.

tests/e2e/Services/Databases/TablesDB/DatabasesCustomServerTest.php (2)

6360-6383: Fix stale comment to match the new 400 expectation

The assertion now correctly expects 400 for invalid point coordinates, but the preceding comment still claims the create should succeed.

Apply:

-        // Coordinates are not validated strictly; creation should succeed
+        // Invalid coordinates must be rejected; creation should fail

---

6649-6669: Avoid duplication: factor the updated LineString into a single variable used in both payload and assertion

The new endpoint [80, 80] looks good. Minor cleanup to keep the payload and expectation in sync.

-            'data' => [
-                'name' => 'Updated Path',
-                'path' => [
-                    [0, 0],
-                    [50, 50],
-                    [80, 80]
-                ] // New LINE STRING
-            ],
+            // Keep request and assertion in sync
+            $newPath = [[0, 0], [50, 50], [80, 80]];
+            'data' => [
+                'name' => 'Updated Path',
+                'path' => $newPath, // New LINE STRING
+            ],

-            $this->assertEquals([
-                [0, 0],
-                [50, 50],
-                [80, 80]
-            ], $row['path']);
+            $this->assertEquals($newPath, $row['path']);

tests/e2e/Services/Databases/Legacy/DatabasesBase.php (3)

5984-5990: Comment labels don’t match updated coordinates

These values aren’t Los Angeles; keep the comment generic to avoid confusion.

-                'location' => [34.0522, -80] // Los Angeles coordinates
+                'location' => [34.0522, -80] // example coordinates (lat, lon)

---

6116-6125: “LA route” label is misleading after longitude change

Coordinates no longer reflect LA; update the comment to a neutral label.

-                'route' => [[34.0522, -80], [34.0736, -90]] // LA route
+                'route' => [[34.0522, -80], [34.0736, -90]] // example route (lat, lon)

---

6253-6262: Polygon comment still says “LA area”

Use a neutral description so test data and commentary align.

-                'area' => [[[34.0522, -80], [34.0736, -80], [34.0736, -90], [34.0522, -90], [34.0522, -80]]] // LA area
+                'area' => [[[34.0522, -80], [34.0736, -80], [34.0736, -90], [34.0522, -90], [34.0522, -80]]] // example area polygon (lat, lon)

tests/e2e/Services/Databases/Legacy/DatabasesCustomServerTest.php (1)

6693-6701: Optional: refetch one updated doc to assert persistence, not just response echo

After asserting the response payload, fetch one document by $id and assert the stored path equals [[0,0],[50,50],[80,80]] to guard against transient serialization or projection differences.

         $this->assertEquals(200, $response['headers']['status-code']);
         $this->assertCount(3, $response['body']['documents']);
 
         // Verify updated documents
         foreach ($response['body']['documents'] as $document) {
             $this->assertEquals('Updated Path', $document['name']);
             $this->assertEquals([
                 [0, 0],
                 [50, 50],
-                [80, 80]
+                [80, 80]
             ], $document['path']);
         }
+
+        // Extra: verify persisted geometry by refetching the first doc
+        $firstId = $response['body']['documents'][0]['$id'];
+        $refetched = $this->client->call(
+            Client::METHOD_GET,
+            "/databases/{$databaseId}/collections/{$collectionId}/documents/{$firstId}",
+            array_merge(['content-type' => 'application/json','x-appwrite-project' => $this->getProject()['$id']], $this->getHeaders())
+        );
+        $this->assertEquals(200, $refetched['headers']['status-code']);
+        $this->assertEquals([[0,0],[50,50],[80,80]], $refetched['body']['path']);

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

tests/e2e/Services/Databases/TablesDB/DatabasesBase.php (1)

7883-7892: Fix degenerate polygon in upsert (zero-area ring due to duplicate/collinear points)

The ring repeats vertices and collapses to a line segment; many spatial backends reject/fuzz this and it undermines test intent. Use a minimal rectangle (distinct corners + closing point).

Apply this patch:

-                'area' => [[[34.0522, -80], [34.0736, -80], [34.0736, -80], [34.0522, -80], [34.0522, -80]]]
+                'area' => [[[34.0522, -80], [34.0736, -80], [34.0736, -79.95], [34.0522, -79.95], [34.0522, -80]]]

And update the assertion:

-        $this->assertEquals([[[34.0522, -80], [34.0736, -80], [34.0736, -80], [34.0522, -80], [34.0522, -80]]], $response['body']['area']);
+        $this->assertEquals([[[34.0522, -80], [34.0736, -80], [34.0736, -79.95], [34.0522, -79.95], [34.0522, -80]]], $response['body']['area']);

tests/e2e/Services/Databases/Legacy/DatabasesBase.php (3)

6119-6124: Rename “LA route” comment to match new coordinates.

Coordinates [[34.0522, -80], [34.0736, -90]] aren’t an LA route; adjust comment only.

-                'route' => [[34.0522, -80], [34.0736, -90]] // LA route
+                'route' => [[34.0522, -80], [34.0736, -90]] // Example route (lat ≈ 34, lon -80 → -90)

---

6256-6261: Rename “LA area” comment to reflect new polygon.

The polygon longitudes -80/-90 aren’t LA; adjust comment to generic wording.

-                'area' => [[[34.0522, -80], [34.0736, -80], [34.0736, -90], [34.0522, -90], [34.0522, -80]]] // LA area
+                'area' => [[[34.0522, -80], [34.0736, -80], [34.0736, -90], [34.0522, -90], [34.0522, -80]]] // Example area polygon (-80/-90 longitudes)

---

5984-5990: Update misleading comment(s): coordinates labeled "Los Angeles" are incorrect

34.0522 is LA latitude but longitudes -80 and -90 are not (LA lon ≈ -118.2437). Either correct the longitudes or change the comments to something like "Example coordinates / route / area". Occurrences: tests/e2e/Services/Databases/Legacy/DatabasesBase.php:5984, 6119, 6256.

-                'location' => [34.0522, -80] // Los Angeles coordinates
+                'location' => [34.0522, -80] // Example coordinates (lat ≈ 34.0522, lon -80)

tests/e2e/Services/Databases/TablesDB/DatabasesBase.php (1)

8160-8163: Nit: normalize spacing for readability; test semantics already correct

Keep coordinate formatting consistent with surrounding code.

-                'lineAttr' => [[1.0, 1.0], [1.1,1.1] , [2.0, 2.0]],
+                'lineAttr' => [[1.0, 1.0], [1.1, 1.1], [2.0, 2.0]],

Also applies to: 8233-8237

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro