chore: update afterbuild to also pass adapter by ChiragAgg5k · Pull Request #10545 · appwrite/appwrite

ChiragAgg5k · 2025-09-24T06:24:00Z

What does this PR do?

Test Plan

Related PRs and Issues

Checklist

Have you read the Contributing Guidelines on issues?
If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

coderabbitai · 2025-09-24T06:24:07Z

📝 Walkthrough

Walkthrough

Adds a nullable string parameter $adapter to Builds::afterBuildSuccess in src/Appwrite/Platform/Modules/Functions/Workers/Builds.php, updates the buildDeployment call site to pass $adapter, adds @param string|null $adapter to the docblock, and introduces a runtime type check throwing if $adapter is not a string or null. No other functional changes are present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

chore: update afterbuild fn #10541 — Also modifies Builds::afterBuildSuccess signature and its call site; related to coordinated signature changes.
feat after build hook #9996 — Introduced the afterBuildSuccess hook that this PR further evolves by adding the $adapter parameter.

Suggested reviewers

loks0n
abnegate
christyjacob4

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.
Description Check	❓ Inconclusive	The PR description contains only the repository contribution template with empty sections and does not describe the change, motivation, or tests, so it is very generic and provides no substantive information beyond the title. This makes it insufficient for reviewers to understand the context or verification steps.	Please update the PR description with a concise summary of what changed, why the adapter parameter was added, any tests performed or required, and links to related issues or PRs so reviewers can properly assess the change.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly describes the primary change: updating the afterbuild flow to also pass an adapter, and it directly maps to the diff that adds a ?string $adapter parameter to afterBuildSuccess and updates its call site. The phrasing is concise and focused, giving reviewers a clear sense of the main intent.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch update-afterbuild-with-adapter

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d99f5c and 85da691.

📒 Files selected for processing (1)

src/Appwrite/Platform/Modules/Functions/Workers/Builds.php (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/Appwrite/Platform/Modules/Functions/Workers/Builds.php

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)

GitHub Check: E2E Service Test (Teams)
GitHub Check: E2E Service Test (VCS)
GitHub Check: E2E Service Test (Locale)
GitHub Check: E2E Service Test (Functions)
GitHub Check: E2E Service Test (FunctionsSchedule)
GitHub Check: E2E Service Test (GraphQL)
GitHub Check: E2E Service Test (Avatars)
GitHub Check: E2E Service Test (Account)
GitHub Check: E2E General Test
GitHub Check: E2E Service Test (Site Screenshots)
GitHub Check: E2E Service Test (Dev Keys)
GitHub Check: scan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-09-24T06:26:37Z

Security Scan Results for PR

Docker Image Scan Results

Package	Version	Vulnerability	Severity
libexpat	2.7.1-r0	CVE-2025-59375	HIGH
golang.org/x/crypto	v0.31.0	CVE-2025-22869	HIGH
golang.org/x/oauth2	v0.24.0	CVE-2025-22868	HIGH
stdlib	1.22.10	CVE-2025-47906	HIGH
stdlib	1.22.10	CVE-2025-47907	HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (2)

src/Appwrite/Platform/Modules/Functions/Workers/Builds.php (2)
1410-1412: Remove unreachable type-check for $adapter.

Parameter is declared as string, so this check is redundant.

Apply this diff:
-        if (!is_string($adapter)) {
-            throw new Exception('adapter must be a string');
-        }
1396-1396: Signature change OK — no overrides found; add missing @param tags

Search found only the declaration at src/Appwrite/Platform/Modules/Functions/Workers/Builds.php:1396; there are no classes extending Builds and no other afterBuildSuccess overrides. Add to the method docblock above afterBuildSuccess:

@param array $runtime

@param string $adapter

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa4a58c and 9d99f5c.

📒 Files selected for processing (1)

src/Appwrite/Platform/Modules/Functions/Workers/Builds.php (3 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/Appwrite/Platform/Modules/Functions/Workers/Builds.php (2)

src/Appwrite/Utopia/Response/Model/Document.php (1)

Document (8-112)

src/Appwrite/Extend/Exception.php (1)

Exception (7-447)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Setup & Build Appwrite Image
GitHub Check: Setup & Build Appwrite Image
GitHub Check: scan

github-actions · 2025-09-24T06:38:21Z

✨ Benchmark results

Requests per second: 1,208
Requests with 200 status code: 217,553
P99 latency: 0.160461063

⚡ Benchmark Comparison

Metric	This PR	Latest version
RPS	1,208	1,001
200	217,553	180,225
P99	0.160461063	0.196387294

chore: update afterbuild pass adapter

9d99f5c

coderabbitai bot reviewed Sep 24, 2025

View reviewed changes

Comment thread src/Appwrite/Platform/Modules/Functions/Workers/Builds.php

allow null adapter

85da691

ChiragAgg5k force-pushed the update-afterbuild-with-adapter branch from 6d9d5e5 to 85da691 Compare September 24, 2025 07:35

loks0n approved these changes Sep 24, 2025

View reviewed changes

loks0n merged commit 04fdab0 into 1.8.x Sep 24, 2025
41 checks passed

stnguyen90 deleted the update-afterbuild-with-adapter branch October 1, 2025 23:58

coderabbitai bot mentioned this pull request Oct 27, 2025

Fix warning builds worker #10705

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update afterbuild to also pass adapter#10545

chore: update afterbuild to also pass adapter#10545
loks0n merged 2 commits into1.8.xfrom
update-afterbuild-with-adapter

ChiragAgg5k commented Sep 24, 2025

Uh oh!

coderabbitai bot commented Sep 24, 2025 •

edited

Loading

Walkthrough

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

github-actions bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ChiragAgg5k commented Sep 24, 2025

What does this PR do?

Test Plan

Related PRs and Issues

Checklist

Uh oh!

coderabbitai bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Possibly related PRs

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

github-actions bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Security Scan Results for PR

Docker Image Scan Results

Source Code Scan Results

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Benchmark results

⚡ Benchmark Comparison

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Sep 24, 2025 •

edited

Loading

github-actions bot commented Sep 24, 2025 •

edited

Loading

github-actions bot commented Sep 24, 2025 •

edited

Loading