Skip to content

chore: update sdks add response models#10554

Merged
abnegate merged 11 commits into1.8.xfrom
update-sdks-add-response-models
Oct 6, 2025
Merged

chore: update sdks add response models#10554
abnegate merged 11 commits into1.8.xfrom
update-sdks-add-response-models

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Sep 26, 2025

📝 Walkthrough

Walkthrough

The PR bumps multiple SDK version numbers in app/config/platforms.php across Client, Console, and Server platforms (e.g., Web 20.1.0 → 21.0.0, Flutter 19.1.0 → 20.0.0, Node.js 19.1.0 → 20.0.0, Ruby 18.1.0 → 19.0.0, etc.). It updates src/Appwrite/Platform/Tasks/SDKs.php to ensure write permissions before removal (using chmod -R u+w), to clear target contents while preserving .git using find . -mindepth 1 ! -path "./.git*" -delete, and to handle existing GitHub PRs by editing the PR title/body with gh pr edit when a PR already exists, including success/failure handling and adjusted cleanup commands.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • loks0n
  • abnegate
  • christyjacob4

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The title claims both “update sdks” and “add response models,” but while the version bumps across SDKs are present, there are no changes adding response models in the diff, so the title is misleading and does not accurately reflect the modifications. Please revise the pull request title to describe the actual changes, such as the SDK version bumps and the script enhancements for PR updates and cleanup, and remove the incorrect reference to adding response models.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ❓ Inconclusive The pull request description is empty and provides no insight into the changes, so there is insufficient context to determine how it relates to the modifications in this branch. Please add a brief description summarizing the key updates in this pull request, such as the SDK version increments and the enhancements to the cleanup and PR tooling scripts, to help reviewers quickly understand the scope of these changes.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-sdks-add-response-models

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf92c25 and a0e8711.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • app/config/platforms.php (14 hunks)
  • composer.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
  • GitHub Check: E2E Service Test (Messaging)
  • GitHub Check: E2E Service Test (FunctionsSchedule)
  • GitHub Check: E2E Service Test (Webhooks)
  • GitHub Check: E2E Service Test (Functions)
  • GitHub Check: E2E Service Test (Databases/Legacy)
  • GitHub Check: E2E Service Test (Locale)
  • GitHub Check: E2E Service Test (Proxy)
  • GitHub Check: E2E Service Test (Realtime)
  • GitHub Check: E2E Service Test (Avatars)
  • GitHub Check: E2E Service Test (Dev Keys)
  • GitHub Check: E2E Service Test (Site Screenshots)
  • GitHub Check: Unit Test
  • GitHub Check: E2E General Test
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: scan
🔇 Additional comments (1)
app/config/platforms.php (1)

14-422: SDK matrix bumps look consistent.

All the version increments line up with the expected +0.1 cadence across the supported SDKs. Looks good.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 26, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.44-r2 CVE-2025-5244 HIGH
binutils 2.44-r2 CVE-2025-5245 HIGH
libexpat 2.7.1-r0 CVE-2025-59375 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH
golang.org/x/oauth2 v0.24.0 CVE-2025-22868 HIGH
stdlib 1.22.10 CVE-2025-47907 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 26, 2025

✨ Benchmark results

  • Requests per second: 1,244
  • Requests with 200 status code: 223,915
  • P99 latency: 0.1563748

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,244 1,033
200 223,915 185,919
P99 0.1563748 0.188107176

@ChiragAgg5k ChiragAgg5k force-pushed the update-sdks-add-response-models branch from 6fba44e to b4dd1df Compare October 1, 2025 06:26
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f5af1ee and 0314547.

📒 Files selected for processing (1)
  • src/Appwrite/Platform/Tasks/SDKs.php (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
  • GitHub Check: E2E Service Test (Messaging)
  • GitHub Check: E2E Service Test (Sites)
  • GitHub Check: E2E Service Test (Webhooks)
  • GitHub Check: E2E Service Test (Users)
  • GitHub Check: E2E Service Test (Health)
  • GitHub Check: E2E Service Test (Migrations)
  • GitHub Check: E2E Service Test (Projects)
  • GitHub Check: E2E Service Test (Locale)
  • GitHub Check: E2E Service Test (Databases/TablesDB)
  • GitHub Check: E2E Service Test (GraphQL)
  • GitHub Check: E2E Service Test (Functions)
  • GitHub Check: E2E Service Test (Databases/Legacy)
  • GitHub Check: E2E Service Test (Console)
  • GitHub Check: E2E Service Test (Account)
  • GitHub Check: E2E General Test
  • GitHub Check: E2E Service Test (Dev Keys)
  • GitHub Check: E2E Service Test (Site Screenshots)
  • GitHub Check: Unit Test
  • GitHub Check: scan

@abnegate abnegate merged commit ee79179 into 1.8.x Oct 6, 2025
41 checks passed
@abnegate abnegate deleted the update-sdks-add-response-models branch October 6, 2025 03:19
@coderabbitai coderabbitai bot mentioned this pull request Oct 8, 2025
This was referenced Oct 22, 2025
This was referenced Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants